chore(l1,l2): disable printing of log tagets. #5184
+17
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR reduces logging verbosity by downgrading several frequently-occurring log messages from debug or info level to trace level, and improves the logging configuration setup. The changes help reduce noise in production logs while maintaining detailed information for deep debugging when needed.
Key changes:
- Downgraded routine operational messages to
tracelevel in transaction broadcasting, peer table management, and blockchain storage updates - Refactored tracing initialization to disable target display and simplify the color/profiling layer configuration
- Added
traceimport to tx_broadcaster.rs to support the new log level
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crates/networking/p2p/tx_broadcaster.rs | Downgraded broadcast operation logs to trace level and added trace import |
| crates/networking/p2p/discv4/peer_table.rs | Downgraded peer table reset message to trace level |
| crates/blockchain/blockchain.rs | Changed storage update log message from debug to trace with clearer wording |
| cmd/ethrex/initializers.rs | Refactored tracing initialization for clarity, disabled target display, and simplified layer composition |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Lines of code reportTotal lines added: Detailed view |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Users using ethrex don't really care where the module comes from.
Description
init_tracingfunction to be clearer